Skip to content

Add timeout parameter to Go To Url keyword and improve tests#481

Open
Dor-bl wants to merge 3 commits into
serhatbolsu:masterfrom
Dor-bl:copilot/add-url-loading-time-argument
Open

Add timeout parameter to Go To Url keyword and improve tests#481
Dor-bl wants to merge 3 commits into
serhatbolsu:masterfrom
Dor-bl:copilot/add-url-loading-time-argument

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This pull request enhances the go_to_url keyword in the AppiumLibrary to support an optional page load timeout parameter and adds comprehensive tests for this new functionality. The main changes include updating the implementation to handle the timeout logic, improving documentation, and ensuring robust test coverage for various scenarios.

Will resolve: #440

Enhancements to go_to_url:

  • The go_to_url method in _applicationmanagement.py now accepts an optional timeout argument, allowing users to specify a maximum page load time using either seconds or time strings. The method temporarily sets the page load timeout, restores the original timeout after navigation, and handles both normal and exceptional cases.
  • The docstring and usage examples for go_to_url have been updated to reflect the new timeout parameter and its supported formats.

Test coverage improvements:

  • Multiple new unit tests have been added in test_applicationmanagement.py to verify:
    • Default behavior when no timeout is given.
    • Correct handling of numeric and string timeouts.
    • Proper restoration of the original timeout after navigation, including when navigation fails.

Copilot AI and others added 3 commits February 1, 2026 22:16
Co-authored-by: Dor-bl <59066376+Dor-bl@users.noreply.github.com>
Co-authored-by: Dor-bl <59066376+Dor-bl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding timeout to Go To Url keyword

2 participants