Add timeout parameter to Go To Url keyword and improve tests#481
Open
Dor-bl wants to merge 3 commits into
Open
Add timeout parameter to Go To Url keyword and improve tests#481Dor-bl wants to merge 3 commits into
Dor-bl wants to merge 3 commits into
Conversation
Co-authored-by: Dor-bl <59066376+Dor-bl@users.noreply.github.com>
Co-authored-by: Dor-bl <59066376+Dor-bl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
go_to_urlkeyword in theAppiumLibraryto support an optional page load timeout parameter and adds comprehensive tests for this new functionality. The main changes include updating the implementation to handle the timeout logic, improving documentation, and ensuring robust test coverage for various scenarios.Will resolve: #440
Enhancements to
go_to_url:go_to_urlmethod in_applicationmanagement.pynow accepts an optionaltimeoutargument, allowing users to specify a maximum page load time using either seconds or time strings. The method temporarily sets the page load timeout, restores the original timeout after navigation, and handles both normal and exceptional cases.go_to_urlhave been updated to reflect the newtimeoutparameter and its supported formats.Test coverage improvements:
test_applicationmanagement.pyto verify: