Skip to content

[CLEANUP chore-dependencies] Major npm dependency upgrades - #159

Draft
sergiitk wants to merge 7 commits into
masterfrom
chore/dependencies-update-major
Draft

[CLEANUP chore-dependencies] Major npm dependency upgrades#159
sergiitk wants to merge 7 commits into
masterfrom
chore/dependencies-update-major

Conversation

@sergiitk

@sergiitk sergiitk commented May 2, 2021

Copy link
Copy Markdown
Owner

What's this PR do?

  • Node modules upgrade:
 devDependencies
   name                     range   from        to      url
 ◉ css-loader               latest  3.6.0    ❯  5.2.4   https://github.com/webpack-contrib/css-loader
 ◉ eslint-plugin-ava        latest  10.5.0   ❯  12.0.0  https://github.com/avajs/eslint-plugin-ava#readme
 ◉ mini-css-extract-plugin  latest  0.9.0    ❯  1.6.0   https://github.com/webpack-contrib/mini-css-extract-plugin
 ◉ node-sass                latest  4.14.1   ❯  5.0.0   https://github.com/sass/node-sass
 ◉ puppeteer-core           latest  5.0.0    ❯  9.0.0   https://github.com/puppeteer/puppeteer#readme
 ◉ react                    latest  16.14.0  ❯  17.0.2  https://reactjs.org/
 ◉ react-dom                latest  16.14.0  ❯  17.0.2  https://reactjs.org/
 ◉ sass-loader              latest  9.0.3    ❯  11.0.1  https://github.com/webpack-contrib/sass-loader
 ◉ sinon                    latest  9.2.4    ❯  10.0.0  https://sinonjs.org/
 ◉ style-loader             latest  1.3.0    ❯  2.0.0   https://github.com/webpack-contrib/style-loader
 ◉ webpack                  latest  4.46.0   ❯  5.36.2  https://github.com/webpack/webpack
 ◉ webpack-cli              latest  3.3.12   ❯  4.6.0   https://github.com/webpack/webpack-cli.git

 dependencies
   name                     range   from        to      url
 ◉ koa-views                latest  6.3.1    ❯  7.0.1   https://github.com/queckezz/koa-views#readme
  • Direct dependencies upgraded for
> yarn output, f.e:
├─ @babel/core@7.2.2
└─ winston@3.2.1

Backward-incompatible upgrades

warning " > eslint-config-airbnb@18.2.1" has unmet peer dependency "eslint-plugin-react-hooks@^4 || ^3 || ^2.3.0 || ^1.7.0".
warning " > optimize-css-assets-webpack-plugin@5.0.4" has incorrect peer dependency "webpack@^4.0.0".

module 1 example

  • Major|Minor|Patch update
  • Explanation

module 2 example

  • Attempted upgrade
    puppeteer latest 1.11.0 ❯ 1.12.1 https://github.com/GoogleChrome/puppeteer#readme
  • Broke acceptance tests, reverted to 1.11.0
  • Explanation

module 3 example

  • Secondary dependency
  • Attempted upgrade from a.b.0 to a.b.1, broke webpack prod build
  • Rolled back to a.b.0 using yarn resolutions
  • Ref related bug

@codecov

codecov Bot commented May 2, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.62%. Comparing base (a9f49da) to head (3b56700).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #159   +/-   ##
======================================
  Coverage    7.62%   7.62%           
======================================
  Files          25      25           
  Lines         538     538           
======================================
  Hits           41      41           
  Misses        497     497           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sergiitk
sergiitk force-pushed the chore/dependencies-update-major branch from 8435677 to d332e76 Compare May 3, 2021 00:28
sergiitk added 4 commits May 3, 2021 01:25
css-loader               3.6.0    ❯  5.2.4
mini-css-extract-plugin  0.9.0    ❯  1.6.0
sinon                    9.2.4    ❯  10.0.
style-loader             1.3.0    ❯  2.0.0
eslint-plugin-ava  10.5.0   ❯  12.0.0
react              16.14.0  ❯  17.0.2
react-dom          16.14.0  ❯  17.0.2
@sergiitk
sergiitk force-pushed the chore/dependencies-update-major branch from 9241584 to 60bece6 Compare May 3, 2021 05:25
@sergiitk
sergiitk force-pushed the chore/dependencies-update-major branch from 60bece6 to 61537b4 Compare May 3, 2021 05:28
sergiitk added 2 commits May 3, 2021 02:33
node-sass    4.14.1  ❯  5.0.0
sass-loader  9.0.3   ❯  11.0.1
Solves
warning " > eslint-config-airbnb@18.2.1" has unmet peer dependency
"eslint-plugin-react-hooks@^4 || ^3 || ^2.3.0 || ^1.7.0".
@sergiitk
sergiitk temporarily deployed to pagerbeauty-staging May 3, 2021 06:46 Inactive
Repository owner deleted a comment Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant