Repository navigation
Reuse section layout state when saving - #171
Merged
Merged
Conversation
Reuse the section-generation bitmap produced during segment layout to identify sections that do not belong to any segment. This avoids repeatedly scanning every segment and its section list for each section during serialization.
Owner
|
Accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
layout_sections_without_segments()repeatedly callsis_section_without_segment(), even though it is equivalent tosection_generated[i] == falsefor section with indexi.section_generatedis created inlayout_segments_and_their_sections()and discarded afterwards, but it would be faster to reuse it.This patch brings
layout_sections_without_segmentsfrom O(S*M) down to O(S), where S is the number of sections and M is the number of segment-to-section associations. I see around 30-40% runtime speedup, especially for large number of segments.