fix: add prepare script so git dependency installs include the built lib output#107
Open
slowsats wants to merge 1 commit into
Open
fix: add prepare script so git dependency installs include the built lib output#107slowsats wants to merge 1 commit into
slowsats wants to merge 1 commit into
Conversation
…lib output Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm, yarn 1, and pnpm run prepare — but not prepack — for git dependencies, so installing this package from a git URL currently ships no lib/. Metro consumers survive via the "react-native": "src/index" field, but anything resolving main/module/types (plain Node, consumer-side tsc) dangles. This adds "prepare": "bob build" alongside the existing prepack.
Verified: a fresh clone installed with --ignore-scripts has no lib/; yarn prepare produces lib/commonjs, lib/module, lib/typescript; an end-to-end npm install git+file://… consumer receives all three targets, and postinstall still extracts the vendored libsodium. Side effect worth knowing: prepare also runs on local installs in the repo (~4s, devDeps are present) — matching how older react-native-builder-bob templates behaved.