fix: prevent exceptions to be rethrown during the cleanup methods of data-driven tests - #3750
Open
zelite wants to merge 1 commit into
Open
fix: prevent exceptions to be rethrown during the cleanup methods of data-driven tests#3750zelite wants to merge 1 commit into
zelite wants to merge 1 commit into
Conversation
…data-driven tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of this PR
Fixes exception handling in data-driven screenplay tests when teardown methods are called. The fix prevents nested exceptions from being thrown when cleanup steps are executed.
Intended effect
Previously: when a datadriven test, executed via SerenityReporter, fails due to an exception, the exception would be rethrown during the teardown method of a screenplay actor, preventing the teardown to run to completion.
With the fix: the teardown method does not rethrow the exception thrown during the test.
How should this be manually tested?
<serenity.version>5.3.12-SNAPSHOT</serenity.version>)Side effects
None identified.
Relevant tickets
#3747