Skip to content

pc: add PCD header unmarshal func#63

Merged
at-wat merged 4 commits into
masterfrom
pc/add-pcd-header-unmarshaller
Jul 29, 2025
Merged

pc: add PCD header unmarshal func#63
at-wat merged 4 commits into
masterfrom
pc/add-pcd-header-unmarshaller

Conversation

@at-wat

@at-wat at-wat commented Jul 28, 2025

Copy link
Copy Markdown
Member

Add a way to parse only the header without accessing the data.

@at-wat at-wat self-assigned this Jul 28, 2025
@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.51020% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.24%. Comparing base (2f8783c) to head (7ff4fd9).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pc/io.go 75.51% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   86.26%   86.24%   -0.03%     
==========================================
  Files          33       33              
  Lines        1922     1941      +19     
==========================================
+ Hits         1658     1674      +16     
- Misses        206      208       +2     
- Partials       58       59       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KanaiHiroaki

This comment was marked as off-topic.

@at-wat

This comment was marked as off-topic.

Comment thread pc/io.go
@at-wat at-wat requested a review from f-fl0 July 29, 2025 04:44

@f-fl0 f-fl0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit 95bc07f into master Jul 29, 2025
15 checks passed
@at-wat at-wat deleted the pc/add-pcd-header-unmarshaller branch July 29, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants