You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prototype evidence: draft PR #1743 and checkpoint 3f11f175. The checkpoint verification matrix and failure classification are preserved in PR #1743.
Outcome
Run the complete stacked implementation through the aggregate routing, topology, static, render, simplify, and independent #1653 gates, with a mechanical ownership audit. This issue validates and removes only what the reviews identify as dead; it introduces no new architecture.
Note: completing this checkpoint proves the #1745 ownership migration, not all of #1671. #1671 closes only after the quality-half disposition review (#1760) has resolved what remains outside this stack.
Estimate: 4-8 focused hours plus CI/render-preview time. Each behavioral child already ran $pinin4fjords:simplify on its own diff (per #1745), so the aggregate pass here is a verification sweep, not a first cleaning.
Scope
Run the four-case gate first, spelled by test id (below).
Run the broad routing gate, topology validator, and render corpus.
Run the exact whole-repository static gates, hooks, and full test suite.
Run $pinin4fjords:simplify over the aggregate production diff as a verification sweep; apply bounded reuse/dead-code findings through the sole writer.
Push a final commit without a CI-skip marker and update the aggregate draft PR description to describe the aggregate diff against main.
The mechanical ownership audit
Every behavioral child's PR body carries a "Coordinates transferred / setters deleted in this PR" section. This issue takes the union of those lists and verifies mechanically:
every listed setter is deleted (grep returns nothing, or only the explicitly retained entries with their cited evidence);
git grep -n 'finalized_owned_segments\|_scalar_component_plan\|_settle_reserved_trunk_axes\|_shared_left_exit_opening\|_landing_domains\|landing-obstacle' -- src tests prints nothing (these were checkpoint-branch-only or never existed; their absence is expected, verify rather than hunt);
exactly one production integration call site for solve_corridor_cohorts, proven by the Trace final settlement and resolve seed-72 routing defects #1746/Join convergence variables into the one cohort problem #1752 instrumentation counters (at most two compiles per render: intent, final; exactly one final solve) together with an exact structural check over call expressions (AST-based, e.g. ast.walk filtering ast.Call nodes whose func resolves to solve_corridor_cohorts across src/). A textual git grep 'solve_corridor_cohorts' -- src is a helpful auxiliary audit but its raw count also matches imports, exports, and the definition, so it is not the proof;
no synthetic-prefix ownership decoding, connector-direction boundary inference, or validation exemption exists;
the stage trace shows at most one GENERAL and one APERTURE batch, at most two compiles (intent, final), exactly one final solve, and zero post-cohort-final mutation, on every corpus fixture;
the render path's re-observation count does not exceed the frozen sequence's requirement (no regression against main's settlement round count outside the sanctioned GENERAL and APERTURE batches).
These landed together at #1761 and must all still pass, plus test_post_freeze_stages_are_validation_only from #1757. Confirm the collected count matches before believing a pass.
Non-goals
No new planner, constraint, owner relationship, retry, clearance cycle, render stage, fixture branch, or collision-specific exception.
Render review: the authoritative diff is the PR preview at https://seqeralabs.github.io/nf-metro/_pr/<PR_NUMBER>/, produced by .github/workflows/pr-renders.yml. Confirm the four hash_seed_determinism/seed_* entries added to scripts/gallery.yaml in #1746 are present so the seed renders appear in the diff. Classify every delta I/N/D by eye; a green suite is not evidence of no visual regression, and every changed render is eyeballed.
Any failing gate that appears to require a new mechanism stops this issue. Record the structural evidence and open a separately reviewed design issue rather than expanding the validation slice or applying a sequential repair.
Parent: #1745
Predecessor: #1757 and its stacked draft PR.
Prototype evidence: draft PR #1743 and checkpoint
3f11f175. The checkpoint verification matrix and failure classification are preserved in PR #1743.Outcome
Run the complete stacked implementation through the aggregate routing, topology, static, render, simplify, and independent #1653 gates, with a mechanical ownership audit. This issue validates and removes only what the reviews identify as dead; it introduces no new architecture.
Note: completing this checkpoint proves the #1745 ownership migration, not all of #1671. #1671 closes only after the quality-half disposition review (#1760) has resolved what remains outside this stack.
Estimate: 4-8 focused hours plus CI/render-preview time. Each behavioral child already ran
$pinin4fjords:simplifyon its own diff (per #1745), so the aggregate pass here is a verification sweep, not a first cleaning.Scope
$pinin4fjords:simplifyover the aggregate production diff as a verification sweep; apply bounded reuse/dead-code findings through the sole writer.main.The mechanical ownership audit
Every behavioral child's PR body carries a "Coordinates transferred / setters deleted in this PR" section. This issue takes the union of those lists and verifies mechanically:
git grep -n 'finalized_owned_segments\|_scalar_component_plan\|_settle_reserved_trunk_axes\|_shared_left_exit_opening\|_landing_domains\|landing-obstacle' -- src testsprints nothing (these were checkpoint-branch-only or never existed; their absence is expected, verify rather than hunt);solve_corridor_cohorts, proven by the Trace final settlement and resolve seed-72 routing defects #1746/Join convergence variables into the one cohort problem #1752 instrumentation counters (at most two compiles per render: intent, final; exactly one final solve) together with an exact structural check over call expressions (AST-based, e.g.ast.walkfilteringast.Callnodes whose func resolves tosolve_corridor_cohortsacrosssrc/). A textualgit grep 'solve_corridor_cohorts' -- srcis a helpful auxiliary audit but its raw count also matches imports, exports, and the definition, so it is not the proof;cohort-finalmutation, on every corpus fixture;main's settlement round count outside the sanctioned GENERAL and APERTURE batches).The four-case gate, spelled by test id
These landed together at #1761 and must all still pass, plus
test_post_freeze_stages_are_validation_onlyfrom #1757. Confirm the collected count matches before believing a pass.Non-goals
Verification
Render review: the authoritative diff is the PR preview at
https://seqeralabs.github.io/nf-metro/_pr/<PR_NUMBER>/, produced by.github/workflows/pr-renders.yml. Confirm the fourhash_seed_determinism/seed_*entries added toscripts/gallery.yamlin #1746 are present so the seed renders appear in the diff. Classify every delta I/N/D by eye; a green suite is not evidence of no visual regression, and every changed render is eyeballed.#1653 hard stop
Any failing gate that appears to require a new mechanism stops this issue. Record the structural evidence and open a separately reviewed design issue rather than expanding the validation slice or applying a sequential repair.