Skip to content

Using aws service gems - #342

Open
rajiv-g wants to merge 2 commits into
sensu-plugins:masterfrom
rajiv-g:issue_293_update-aws-dependencies
Open

Using aws service gems#342
rajiv-g wants to merge 2 commits into
sensu-plugins:masterfrom
rajiv-g:issue_293_update-aws-dependencies

Conversation

@rajiv-g

@rajiv-g rajiv-g commented May 6, 2019

Copy link
Copy Markdown
Contributor

Pull Request Checklist

#293

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

@zeninfinity

zeninfinity commented May 6, 2019

Copy link
Copy Markdown

Looks like this did not install them correctly. Lots of:

GemWrappers: Can not wrap missing file: c_rehash
GemWrappers: Can not wrap missing file: makedepend
GemWrappers: Can not wrap missing file: check-banner.rb
GemWrappers: Can not wrap missing file: rake-compiler
GemWrappers: Can not wrap missing file: sensu-translator
GemWrappers: Can not wrap missing file: check-uptime.rb
GemWrappers: Can not wrap missing file: metrics-uptime.rb
GemWrappers: Can not wrap missing file: aws.rb
GemWrappers: Can not wrap missing file: check-head-redirect.rb
GemWrappers: Can not wrap missing file: metrics-http-json.rb
GemWrappers: Can not wrap missing file: check-last-modified.rb
GemWrappers: Can not wrap missing file: check-http.rb
GemWrappers: Can not wrap missing file: metrics-curl.rb
GemWrappers: Can not wrap missing file: check-http-cors.rb

And ultimately did not install the checks into /opt/sensu/embedded/bin/ correctly.

See conversation in #293

ZZ

@rajiv-g

rajiv-g commented May 7, 2019

Copy link
Copy Markdown
Contributor Author

@majormoses @zeninfinity I can successfully install these in sensu & binstubs are created as well in embedded sensu ruby. But still it took more time to parse the dependencies of aws-sdk in gemspec.

@majormoses

Copy link
Copy Markdown
Member

does this PR superseded #335?

@rajiv-g

rajiv-g commented May 9, 2019

Copy link
Copy Markdown
Contributor Author

@majormoses Yes its superseded for #335, But need your ideas/suggestion on #293 (comment)

@majormoses

Copy link
Copy Markdown
Member

Sorry for the long silence, I replied on the PR and am ready to move forward with something as long as we are moving forward and not dropping any features that rely on v3 sdks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants