Fix bug in MultiHeadAttention - #40
Merged
Merged
Conversation
Owner
|
Great catch! Current codebase doesn't utilize |
Contributor
Author
|
Great! P.S., I know this is out of the scope of the repo but is there any desire to have sortformer models included? Think they would all fit in some sort of "mlx-NeMo-asr" library. Thanks. |
Owner
|
Yeah, that'd be pretty awesome! In fact, I half-implemented Canary on #30 (kind of staled because of school stuffs, but I think I'll finish it someday). Sortformer would be nice too because they all share same Conformer architecture! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I'm using modules in this package for re-implementing Sortformer into MLX (and hopefully make adapter between canary and sortformer). I ran into this bug with MultiHeadAttention when writing the TransformerEncoder layer because n_feat wasn't set. Not sure if I was supposed to do something else in initializing them but I changed the forwarding.