Read browser sources as UTF-8 in the runtime build test - #26
Merged
Conversation
tests/test_web_runtime_build.py read the stamped app.js and worker files with the platform default encoding, so on Windows (cp1252) the two test_runtime_urls_and_worker_are_immutable cases failed with a UnicodeDecodeError on the first non-ASCII character in app.js, and the master CI run for 13975b0 went red on the Windows bounded suite while passing on Linux. The build script itself already writes UTF-8; read the files the same way. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qwh26ysS8vtKGg6SF4PGtP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_web_runtime_build.py(added in 13975b0) reads the stampedapp.jsand worker files with the platform default encoding. On the Windows runner that is cp1252, so bothtest_runtime_urls_and_worker_are_immutablecases fail with aUnicodeDecodeErroron the first non-ASCII character inapp.js. Master's own CI run for 13975b0 is red on the Windows bounded suite for this reason (Linux passes), and PR #25 inherited the failure.The build script already writes these files as UTF-8; the test now reads them the same way. Reproduced and verified locally on Windows (2 failed → 3 passed), ruff clean, test-only change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Qwh26ysS8vtKGg6SF4PGtP