Skip to content

Restore live controller feedback and motor visualization - #3

Merged
sendement merged 3 commits into
sendement:mainfrom
DanteFroMGiti:fix/live-controller-feedback
Sep 14, 2026
Merged

sendement merged 3 commits into
sendement:mainfrom
DanteFroMGiti:fix/live-controller-feedback

Conversation

@DanteFroMGiti

@DanteFroMGiti DanteFroMGiti commented Sep 14, 2026 •

Copy link
Copy Markdown

Summary

  • unify connection status and transport controls with one rounded visual style
  • propagate pressed-control glow to every controller preview
  • restore live motor telemetry on vibration settings and after engine restart
  • align profile detail meters to a shared starting column
  • give each physical motor its own side-specific glow: cyan above and purple below
  • scale both glow zones from the live level of the matching left or right motor

Validation

  • QT_QPA_PLATFORM=offscreen pytest -q — 317 passed
  • python3 -m py_compile ui.py
  • git diff --check
  • CI passed on Python 3.10 and 3.13

@DanteFroMGiti DanteFroMGiti changed the title Restore live controller feedback across UI pages Restore live controller feedback and motor visualization Sep 14, 2026

@sendement sendement left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix — this is a real regression I introduced myself with the page-visibility telemetry gating, and it's good to see it addressed with a shared fresh_visual_snapshot() helper. Tests pass here too (316/316). A few things worth a look before merging:

  • Trigger squeeze text no longer shows (ui.py ~2151, HomePage._poll_meter): the loop that used to merge an engaged trigger's held pressure into feedback (main branch ui.py:2116-2118) is gone. The controller graphic still glows for L2/R2 via held, but the feedback label's text (e.g. "Left Trigger 80%") never mentions it anymore, since the engine doesn't populate feedback for trigger virtual codes on its own. Picture and text now disagree whenever a trigger preset is engaged.
  • ButtonHapticPage._poll_feedback still hand-rolls the staleness check instead of using the new fresh_visual_snapshot() helper this PR wires into every other page (Home/Triggers/Advanced/Led). Minor, but it leaves the same ".5s freshness" logic in two places — a future tweak to the helper won't reach this one page.
  • HomePage.motor_level_state is now write-only — AdvancedPage was its only reader and this PR switches it to read engine.level_queue directly instead, but HomePage still updates the now-unused attribute every poll. Harmless, just dead state worth trimming while you're in here.

Happy to take a look again once these are in.

@sendement
sendement merged commit e08399d into sendement:main Sep 14, 2026
2 checks passed
sendement added a commit that referenced this pull request Sep 14, 2026
PR #3 restored live controller feedback across pages but dropped the merge
that puts an engaged trigger preset's held pressure into HomePage's
feedback text - the controller graphic still glowed for L2/R2, but the
label never mentioned it. Restores that merge (gated on a preset actually
being configured on that side, as before) and adds a regression test that
fails without it.

Also folds ButtonHapticPage._poll_feedback onto the shared
fresh_visual_snapshot() helper instead of hand-rolling the same staleness
check, and removes HomePage.motor_level_state, which nothing has read
since AdvancedPage switched to reading engine.level_queue directly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D3vZeeKDFE7YATwLmFaqAf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants