Repository navigation
Restore live controller feedback and motor visualization - #3
Merged
sendement merged 3 commits intoSep 14, 2026
Merged
Conversation
sendement
reviewed
Sep 14, 2026
sendement
left a comment
Owner
There was a problem hiding this comment.
Thanks for the fix — this is a real regression I introduced myself with the page-visibility telemetry gating, and it's good to see it addressed with a shared fresh_visual_snapshot() helper. Tests pass here too (316/316). A few things worth a look before merging:
- Trigger squeeze text no longer shows (
ui.py~2151,HomePage._poll_meter): the loop that used to merge an engaged trigger's held pressure intofeedback(main branch ui.py:2116-2118) is gone. The controller graphic still glows for L2/R2 viaheld, but the feedback label's text (e.g. "Left Trigger 80%") never mentions it anymore, since the engine doesn't populatefeedbackfor trigger virtual codes on its own. Picture and text now disagree whenever a trigger preset is engaged. ButtonHapticPage._poll_feedbackstill hand-rolls the staleness check instead of using the newfresh_visual_snapshot()helper this PR wires into every other page (Home/Triggers/Advanced/Led). Minor, but it leaves the same ".5s freshness" logic in two places — a future tweak to the helper won't reach this one page.HomePage.motor_level_stateis now write-only —AdvancedPagewas its only reader and this PR switches it to readengine.level_queuedirectly instead, butHomePagestill updates the now-unused attribute every poll. Harmless, just dead state worth trimming while you're in here.
Happy to take a look again once these are in.
sendement
added a commit
that referenced
this pull request
Sep 14, 2026
PR #3 restored live controller feedback across pages but dropped the merge that puts an engaged trigger preset's held pressure into HomePage's feedback text - the controller graphic still glowed for L2/R2, but the label never mentioned it. Restores that merge (gated on a preset actually being configured on that side, as before) and adds a regression test that fails without it. Also folds ButtonHapticPage._poll_feedback onto the shared fresh_visual_snapshot() helper instead of hand-rolling the same staleness check, and removes HomePage.motor_level_state, which nothing has read since AdvancedPage switched to reading engine.level_queue directly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3vZeeKDFE7YATwLmFaqAf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation