[CLNP-7537] revert: improve keyboard avoidance behavior for Android API 35+ - #261
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 11.20% 11.22% +0.02%
==========================================
Files 360 360
Lines 8732 8716 -16
Branches 2486 2460 -26
==========================================
Hits 978 978
- Misses 7678 7737 +59
+ Partials 76 1 -75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts keyboard avoidance behavior improvements that were specifically added for Android API 35+ due to compatibility issues with different React Native versions. The changes remove edge-to-edge layout handling logic and revert to the previous keyboard avoidance implementation.
- Removes Android API 35+ specific keyboard avoidance logic including conditional padding behavior
- Eliminates keyboard visibility tracking state and related event listeners
- Simplifies keyboard vertical offset calculation back to the original implementation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
[CLNP-7537](https://sendbird.atlassian.net/browse/CLNP-7537)
Description Of Changes
Android API 35+ 에서 edge-to-dege 대응으로 추가했던 로직이 RN 버전에따라 높이 값이 안맞는 문제가 발견 되었습니다.
ReactNative에서 관련 이슈가 등록된 상태라 언젠가 수정이 될거로 예상되고
추후 호환성을 위해 일단 코드 롤백하고, 릴리즈 노트와 고객에게 MainActivity.kt를 수정하도록 가이드할 예정입니다
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_