[CLNP-7474] feat: supprot-for-text-input-props - #255
Merged
Conversation
…SendInput components
…pChannel (e.g. autoCorrect)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 11.26% 11.25% -0.01%
==========================================
Files 360 360
Lines 8680 8686 +6
Branches 2332 2472 +140
==========================================
Hits 978 978
+ Misses 7701 7632 -69
- Partials 1 76 +75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for controlling autoCorrect functionality in GroupChannelInput and fixes an iOS-specific issue where text remained in the input field after sending messages when autoCorrect was enabled.
- Adds
partialTextInputPropsprop to allow configuration of TextInput properties likeautoCorrect - Implements iOS-specific fix for text clearing issue when
autoCorrectis enabled - Threads the new prop through the component hierarchy from GroupChannel to input components
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/uikit-react-native/src/fragments/createGroupChannelFragment.tsx | Passes partialTextInputProps to GroupChannelInput component |
| packages/uikit-react-native/src/domain/groupChannel/types.ts | Adds TypeScript definitions for partialTextInputProps |
| packages/uikit-react-native/src/components/ChannelInput/index.tsx | Defines the interface for partialTextInputProps with restricted TextInputProps |
| packages/uikit-react-native/src/components/ChannelInput/SendInput.tsx | Implements iOS-specific text clearing fix and applies partialTextInputProps to TextInput |
| packages/uikit-react-native/src/components/ChannelInput/EditInput.tsx | Applies partialTextInputProps to EditInput TextInput component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
[CLNP-7474](https://sendbird.atlassian.net/browse/CLNP-7474)
Description Of Changes
GroupChannelInput 에서 autoCorrect기능을 on/off 할수 있도록 추가하였습니다.
autoCorrect 가 true 일때 iOS 에서 메세지 전송이후, 텍스트가 남아있는 현상 수정하였습니다.
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_