Inject SseServer instead of the static SSE facade - #45
Conversation
Part of tk-facades-sse-server - DemoExecutionShowcaseService takes the container-managed SseServer via #[InjectAsReadonly]; the heartbeat console command stays on the facade (static context). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WfzwnJKXsFfsGVqRkHEbCD
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe service now injects ChangesSSE delivery
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change replaces a static SSE call with the container-managed service in one application service; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the demo execution “showcase” SSE emission path to use a container-managed SseServer instance rather than the static AsyncResourceSseServer facade, aligning with the ep-kill-static-facades effort while keeping the console heartbeat on the facade.
Changes:
- Replaced
AsyncResourceSseServer::deliver(...)with an injectedSseServer->deliver(...)call. - Added
SseServerdependency injection toDemoExecutionShowcaseServicevia#[InjectAsReadonly].
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
What
Part of
ep-kill-static-facades:DemoExecutionShowcaseServicetakes the container-managedSseServervia#[InjectAsReadonly]; the heartbeat console command stays on the facade (static context, allowlisted in the guard rule).Requires the paired semitexa-ssr PR (SseServer).
Verification
🤖 Generated with Claude Code
https://claude.ai/code/session_01WfzwnJKXsFfsGVqRkHEbCD
Summary by CodeRabbit