Add tarfile-unsafe-extraction rule (CWE-22 tarslip) - #4033
Open
rahulreddykarne wants to merge 1 commit into
Open
Add tarfile-unsafe-extraction rule (CWE-22 tarslip)#4033rahulreddykarne wants to merge 1 commit into
rahulreddykarne wants to merge 1 commit into
Conversation
Adds a rule detecting tar-archive extraction via extractall()/extract() with no filter= argument - the CVE-2007-4559 "tarslip" path-traversal class (CWE-22). Motivating case: CVE-2026-43637. Validated against torchvision, keras, scikit-learn, and cornac: 1 true positive (torchvision's _extract_tar) and 0 false positives. Ignores every filter= form and all zipfile usage. Known limitation: matches inline open→extract usage and helpers typed tarfile.TarFile; does not follow archives passed into untyped helper functions, since the open-source Semgrep taint engine is intra-function.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a rule detecting tar-archive extraction via extractall()/extract() with no filter= argument - the CVE-2007-4559 "tarslip" path-traversal class (CWE-22). Motivating case: CVE-2026-43637.
Validated against torchvision, keras, scikit-learn, and cornac: 1 true positive (torchvision's _extract_tar) and 0 false positives. Ignores every filter= form and all zipfile usage.
Known limitation: matches inline open→extract usage and helpers typed tarfile.TarFile; does not follow archives passed into untyped helper functions, since the open-source Semgrep taint engine is intra-function.