This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Improve publish workflow#10
Open
marcokrikke wants to merge 7 commits into
Open
Conversation
marcokrikke
force-pushed
the
fb_gh-workflow
branch
2 times, most recently
from
October 4, 2019 12:58
ca92d89 to
ba1c2a2
Compare
added 6 commits
October 4, 2019 15:11
Build into the /build folder and deploy that folder to the gh-pages branch.
This way we do not depend on a untrusted CDN anymore.
marcokrikke
force-pushed
the
fb_gh-workflow
branch
from
October 4, 2019 13:11
13fea84 to
66d57a6
Compare
marcokrikke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The API specs project now uses Github Workflows to lint, build and publish the resulting documentation.
Changes in this PR:
builddirectory when pushed tomasterbranch.builddirectory to thegh-pagesbranch. This seems to be best practice when manually including assets (see next change).Testing
Tested using the branch of this PR as the Github Workflow trigger.
Documentation
README has been updated.
Upgrade notes for breaking changes
UPGRADE_NOTES.mdhas been updated (when applicable).