Skip to content

fix(ci): prevent older release tags from overwriting Docker latest tag #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrjcap wants to merge 5 commits into
base: develop
Choose a base branch
from
+44 −4
Open

fix(ci): prevent older release tags from overwriting Docker latest tag #4323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfe3c2c
fix(ci): prevent older release tags from overwriting Docker latest tag
mrjcap Oct 8, 2026
66a4418
fix(ci): pass ref_name via env var to prevent command injection
mrjcap Oct 8, 2026
445b9f3
ci: serialize release runs to prevent out-of-order image publishing
mrjcap Oct 8, 2026
08a1b4c
ci: scope release concurrency group to ref to prevent dropping pendin…
mrjcap Oct 8, 2026
1e1f5f5
fix(ci): serialize releases with shared concurrency queue and harden …
mrjcap Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions .github/workflows/community_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ name: Community Release
- 'v[0-9]+.[0-9]+.[0-9]+'
- v*-rc*

concurrency:
group: community-release
cancel-in-progress: false
Comment thread
coderabbitai[bot] marked this conversation as resolved.
queue: max

permissions:
contents: write

Expand Down Expand Up @@ -69,6 +74,20 @@ jobs:
steps:
- name: Checkout source
uses: actions/checkout@v7
with:
fetch-depth: 0

- name: Check if latest version
id: is_latest
env:
RELEASE_TAG: ${{ github.ref_name }}
run: |
HIGHEST_TAG=$(git tag -l --sort=-v:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | head -n 1 || true)
if [ "$RELEASE_TAG" = "$HIGHEST_TAG" ]; then
echo "is_latest=true" >> "$GITHUB_OUTPUT"
else
echo "is_latest=false" >> "$GITHUB_OUTPUT"
fi

- name: Setup qemu
id: qemu
Expand Down Expand Up @@ -100,7 +119,7 @@ jobs:
tags: |
type=raw,value=${{ github.ref_name }}
flavor: |
latest=true
latest=${{ steps.is_latest.outputs.is_latest }}

- name: Server build
uses: docker/build-push-action@v7
Expand Down Expand Up @@ -156,7 +175,7 @@ jobs:
tags: |
type=raw,value=${{ github.ref_name }}
flavor: |
latest=true
latest=${{ steps.is_latest.outputs.is_latest }}

- name: Runner build
uses: docker/build-push-action@v7
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/pro_selfhosted_beta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ jobs:
maintainer=Semaphore UI <support@semaphoreui.com>
tags: |
type=raw,value=${{ github.ref_name }}
flavor: |
latest=false

- name: Server build
uses: docker/build-push-action@v7
Expand Down Expand Up @@ -230,6 +232,8 @@ jobs:
maintainer=Semaphore UI <support@semaphoreui.com>
tags: |
type=raw,value=${{ github.ref_name }}
flavor: |
latest=false

- name: Runner build
uses: docker/build-push-action@v7
Expand Down
21 changes: 19 additions & 2 deletions .github/workflows/pro_selfhosted_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ name: Pro Self-Hosted Release
tags:
- 'v[0-9]+.[0-9]+.[0-9]+'

concurrency:
group: pro-selfhosted-release
cancel-in-progress: false
queue: max

permissions:
contents: write

Expand Down Expand Up @@ -86,6 +91,18 @@ jobs:
with:
fetch-depth: 0

- name: Check if latest version
id: is_latest
env:
RELEASE_TAG: ${{ github.ref_name }}
run: |
HIGHEST_TAG=$(git tag -l --sort=-v:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$' | head -n 1 || true)
if [ "$RELEASE_TAG" = "$HIGHEST_TAG" ]; then
Comment thread
coderabbitai[bot] marked this conversation as resolved.
echo "is_latest=true" >> "$GITHUB_OUTPUT"
else
echo "is_latest=false" >> "$GITHUB_OUTPUT"
fi

- name: Determine PRO branch
uses: ./.github/actions/determine-pro-branch
with:
Expand Down Expand Up @@ -133,7 +150,7 @@ jobs:
tags: |
type=raw,value=${{ github.ref_name }}
flavor: |
latest=true
latest=${{ steps.is_latest.outputs.is_latest }}

- name: Server build
uses: docker/build-push-action@v7
Expand Down Expand Up @@ -215,7 +232,7 @@ jobs:
tags: |
type=raw,value=${{ github.ref_name }}
flavor: |
latest=true
latest=${{ steps.is_latest.outputs.is_latest }}

- name: Runner build
uses: docker/build-push-action@v7
Expand Down
Loading