Adding README document for self-contained tests - #9
Open
selldinesh wants to merge 8 commits into
Open
Conversation
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
chrispsommers
suggested changes
May 24, 2023
chrispsommers
left a comment
There was a problem hiding this comment.
Hi, this is a good start, but there is not enough context. Some suggestions:
- make a new directory
usecases/selfcontained-dutand rename this fileusecases/selfcontained-dut/README.md. This is where it will live when we're all done; treat this as a draft. This is about a self-contained DUT testbed, not about just about back to back testing. Someone might even use it with snake testing, or internal loopbacks eventually. - write it as if it were a step-by-step tutorial for demonstrating this use-case. Also, in the section https://github.com/selldinesh/SAI-Challenger/tree/main/usecases#readme, add something like "See selfcontained-dut for a tutorial" so it links to this README.
- Add a link to the diagram e.g.  has nothing to go on but this; what information does he need to get to the same place you did?
Hope this sheds some light on my approach.
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the readme document for running tests in a self-contained manner using ixia-c.
As the first step towards the process we have tried sending 100 packets using scapy on the sonic dut ports which are connected in a back to back manner and documenting the steps done