Skip to content

bugfix: Also skip gitcache executable named git - #162

Merged
seeraven merged 2 commits into
seeraven:masterfrom
mering:bugfix/gitcache-named-git
Sep 11, 2026
Merged

seeraven merged 2 commits into
seeraven:masterfrom
mering:bugfix/gitcache-named-git

Conversation

@mering

@mering mering commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Previously only symlinks have been skipped reliably. When gitcache was named git directly, it found itself resulting in infinite recursion.
Now the logic to find the real git executable always skips itself.

Previously only symlinks have been skipped reliably.
When gitcache was named git directly, it found itself
resulting in infinite recursion.
Now the logic to find the real git executable always
skips itself.
@mering
mering force-pushed the bugfix/gitcache-named-git branch from dc59fc3 to a3693cb Compare September 11, 2026 15:12
@seeraven seeraven self-assigned this Sep 11, 2026

@seeraven seeraven left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your PR!

@seeraven
seeraven merged commit a60743f into seeraven:master Sep 11, 2026
10 checks passed
@mering
mering deleted the bugfix/gitcache-named-git branch September 11, 2026 15:29
@mering

mering commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor Author

@seeraven Thanks for your quick reviews and merges. Any chance you could create a release including these changes soon?

@seeraven

Copy link
Copy Markdown
Owner

@seeraven Thanks for your quick reviews and merges. Any chance you could create a release including these changes soon?

Finally I had some time to work on this. ;-) I've released the new version https://github.com/seeraven/gitcache/releases/tag/v1.0.35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants