Repository navigation
bugfix: Check the mirror existence while holding the mirror lock - #161
Merged
Merged
Conversation
The database was queried for the existence of the mirror before the mirror lock was aquired. Two gitcache processes starting with an empty cache both saw a missing mirror, so the process getting the lock as the second one deleted the mirror the first one had just created and cloned it again, breaking the operations of the other processes on that mirror. Query the database while holding the lock. Co-authored-by: Cursor <cursoragent@cursor.com>
seeraven
approved these changes
Sep 11, 2026
seeraven
left a comment
seeraven
left a comment
Owner
There was a problem hiding this comment.
Good catch of this race condition! Again, feel free to give yourself credit for this nice finding and fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The database was queried for the existence of the mirror before the mirror lock was acquired. Two gitcache processes starting with an empty cache both saw a missing mirror, so the process getting the lock as the second one deleted the mirror the first one had just created and cloned it again, breaking the operations of the other processes on that mirror.
Query the database while holding the lock.