feat: add custom signet support#192
Draft
oleonardolima wants to merge 3 commits into
Draft
Conversation
oleonardolima
force-pushed
the
feat/add-custom-signet-support
branch
from
3b5017e to
5f7ea64
Compare
- bind btck_chain_parameters_create_signet in libbitcoinkernel-sys - add ChainParams::new_signet and ContextBuilder::signet - add tests for both paths Co-Authored-By: Davidson-Souza <me@dlsouza.lol> Co-Authored-By: Johnny Santos <johnnyadsantos@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
oleonardolima
force-pushed
the
feat/add-custom-signet-support
branch
from
5f7ea64 to
5882002
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been discussing and working with @edilmedeiros in @vinteumorg study sessions, and as mentioned in bitcoin/bitcoin#35362, currently there's no way to use
rust-bitcoinkernelwith a custom signet.As implemented in bitcoin/bitcoin#35464, there's now a new method to create the chain parameters with a custom signet challenge through the bitcoinkernel API.
In the latest study session we're reviewing bitcoin/bitcoin#35464 and implemented the last commit below to expose and use the new method through
rust-bitcoinkernelAPI.cc @johnnyasantoss @Davidson-Souza