validation: include unused mempool space in coins cache limit#30
Open
w0xlt wants to merge 11 commits into
Open
validation: include unused mempool space in coins cache limit#30w0xlt wants to merge 11 commits into
w0xlt wants to merge 11 commits into
Conversation
As a first step add `removeRecursive` to the interface.
And add MaybeUpdateMempoolForReorg to the mempool interface.
Explicitly add boost headers to zmq lib
sedited
force-pushed
the
mempoolout_rebase
branch
2 times, most recently
from
40b243d to
8be8bf2
Compare
Owner
|
Many thanks again, took the non-test changes. |
Author
|
Opened bitcoin#35490 |
sedited
force-pushed
the
mempoolout_rebase
branch
from
8be8bf2 to
02db4cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the existing behavior where the coins cache can borrow unused
-maxmempoolspace.In this branch,
Chainstate::GetCoinsCacheSizeState()was changed to pass0formax_mempool_size_bytes, so unused mempool space was no longer included in the coins cache limit. The startup log still says unused mempool space can be used for the in-memory UTXO set, but after this change that was no longer true.This adds
kernel::Mempool::maxSizeBytes()so validation can retrieve the configured mempool limit through the new mempool interface instead of accessingCTxMemPooldirectly.Also adds a unit test covering the default
GetCoinsCacheSizeState()path.