validation: restore non-empty mempool check before snapshot activation#29
Open
w0xlt wants to merge 11 commits into
Open
validation: restore non-empty mempool check before snapshot activation#29w0xlt wants to merge 11 commits into
w0xlt wants to merge 11 commits into
Conversation
As a first step add `removeRecursive` to the interface.
And add MaybeUpdateMempoolForReorg to the mempool interface.
Explicitly add boost headers to zmq lib
sedited
force-pushed
the
mempoolout_rebase
branch
from
222e2fe to
40b243d
Compare
Owner
|
Thank you for checking this out! Do you want to submit the functional test change upstream? Seems like that ought be covered by a test. |
sedited
force-pushed
the
mempoolout_rebase
branch
from
40b243d to
8be8bf2
Compare
Author
|
Thanks. This specific test already exists on master (introduced in PR 29394) but it was removed in e6a0a84#diff-8eaa6b77b4e4f242deb67950425cb6b6b7de5370c56a1e8fa7e3a12e95df0a9d. |
Owner
|
Heh, completely forgot that I did that :P |
sedited
force-pushed
the
mempoolout_rebase
branch
from
8be8bf2 to
02db4cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the existing master behavior that rejects snapshot activation when the mempool is non-empty.
The guard was dropped when validation stopped accessing
CTxMemPooldirectly and started using kernel::Mempool. This adds a smallempty()query to the interface soActivateSnapshot()can keep the same behavior without reintroducing aCTxMemPooldependency.Also adds a functional regression test in
feature_assumeutxo.py.