Fix: Remove deprecated suggestion-mode from .pylintrc and patch unassigned variable - #56
Open
Ashishmillipixels01 wants to merge 2 commits into
Open
Conversation
Ashishmillipixels01
requested review from
bvandekerkhof,
davidrandell84 and
mattj89
as code owners
July 10, 2026 07:46
bvandekerkhof
previously approved these changes
Jul 14, 2026
bvandekerkhof
left a comment
bvandekerkhof
left a comment
Collaborator
There was a problem hiding this comment.
Please update the commits to have verified signature.
bvandekerkhof
dismissed
their stale review
July 14, 2026 07:15
Need verified signatures to pass check
bvandekerkhof
self-requested a review
July 14, 2026 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running
pylintcurrently crashes with an unrecognized option error in newer versions because of the deprecatedsuggestion-modein.pylintrc. This PR removes the deprecated option so the linting pipeline succeeds.Furthermore, upon running the linter, an
E0606 (possibly-used-before-assignment)issue was surfaced insrc/pyelq/preprocessing.py. This PR initializestime_outand renames the redefinedfieldvariable to resolve the scoping bug.