fix: switch E2E CI from cli_server to cgw strategy - #93
Conversation
The cli-server is being removed from the operator. Switch the E2E workflow to use the cgw strategy with the Developer Portal URL for CLI binary downloads. The version is controlled by the CLI_CGW_VERSION env var at the top of the workflow. Also remove cli-server.local from /etc/hosts. Signed-off-by: Sachin Sampras M <sampras343@gmail.com>
PR Summary by QodoSwitch E2E CLI downloads to the content gateway
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. Content gateway path malformed
|
| CLI_STRATEGY: cli_server | ||
| CLI_SERVER_URL: "http://cli-server.local" | ||
| CLI_STRATEGY: cgw | ||
| CGW_URL: "https://developers.redhat.com/content-gateway/file/RHTAS/${{ env.CLI_CGW_VERSION }}" |
There was a problem hiding this comment.
1. Content gateway path malformed 🐞 Bug ≡ Correctness
The new CGW_URL omits the required /cgw path segment, causing the strategy to construct CLI download URLs under the wrong endpoint. CLI prerequisite setup will fail, preventing the E2E tests from running.
Agent Prompt
## Issue description
The E2E workflow configures a Content Gateway base URL that omits the documented `/cgw` path segment. Update it to `https://developers.redhat.com/content-gateway/file/cgw/RHTAS/${{ env.CLI_CGW_VERSION }}` so the strategy constructs valid CLI archive URLs.
## Issue Context
The `cgw` strategy appends each platform-specific archive filename directly to `CGW_URL`. The repository documentation defines the base path as `/content-gateway/file/cgw/RHTAS/<version>`.
## Fix Focus Areas
- .github/workflows/e2e.yml[128-128]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Summary
Switch the E2E workflow from
CLI_STRATEGY=cli_servertoCLI_STRATEGY=cgwwith the Developer Portal URL. The cli-server is being removed from the operator (securesign/secure-sign-operator#2143).Changes
CLI_CGW_VERSION: "1.4.2"env var at the workflow top levelCLI_STRATEGY: cli_server/CLI_SERVER_URLwithCLI_STRATEGY: cgw/CGW_URLusing the version env varcli-server.localfrom/etc/hostsDepends on