🎨 Palette: [UX improvement] Add ARIA state attributes to NavMenu toggles#124
🎨 Palette: [UX improvement] Add ARIA state attributes to NavMenu toggles#124secrooq wants to merge 1 commit into
Conversation
- Added `aria-expanded` and missing `aria-label`s to mobile and user menus in NavMenu.tsx. Co-authored-by: secrooq <81346684+secrooq@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Added missing
aria-expandedattributes to track the open/closed states of mobile hamburger, mobile profile, and user dropdown menus. Also added missingaria-labels to close buttons and toggles.🎯 Why
Ensures that screen readers and other assistive technologies can accurately communicate the state of interactive components (open vs closed) and their purpose, providing a much more intuitive navigation experience.
📸 Before/After
(No visual changes; this is an accessibility enhancement under the hood).
♿ Accessibility
aria-expanded={isMobileMenuOpen}andaria-label="Toggle Navigation Menu"to the main hamburger icon.aria-expanded={isMobileProfileOpen}andaria-label="Toggle Mobile Profile Menu"to the mobile user icon.aria-labels to the Close (X) buttons inside both mobile drawers.aria-expanded={isUserDropdownOpen}andaria-label="Toggle User Dropdown Menu"to the desktop profile widget.PR created automatically by Jules for task 13375938936793072497 started by @secrooq