Skip to content

🎨 Palette: Add dynamic ARIA attributes to interactive toggles#102

Open
secrooq wants to merge 1 commit into
mainfrom
palette-dynamic-aria-labels-13060700835831662234
Open

🎨 Palette: Add dynamic ARIA attributes to interactive toggles#102
secrooq wants to merge 1 commit into
mainfrom
palette-dynamic-aria-labels-13060700835831662234

Conversation

@secrooq

@secrooq secrooq commented Jun 29, 2026

Copy link
Copy Markdown
Owner

💡 What: Added aria-expanded and dynamic aria-label attributes to multiple interactive toggles (mobile menus, profile dropdown, support widget) across the application. Also added aria-labels to previously unlabelled "X" close buttons within those menus.

🎯 Why: Static ARIA labels like "Toggle Navigation Menu" don't convey the current state to screen reader users. Without aria-expanded, users rely on guesswork to determine if an action opened or closed a menu. Dynamically updating the label to explicitly state "Open..." or "Close..." significantly improves the accessibility and usability of these components.

📸 Before/After: No visual changes. Purely semantic HTML improvements.

Accessibility:

  • Added aria-expanded={isOpen} to toggles.
  • Added dynamic aria-label={isOpen ? "Close Menu" : "Open Menu"} to toggles.
  • Added static aria-label="Close..." to internal drawer close buttons.

PR created automatically by Jules for task 13060700835831662234 started by @secrooq

- Identified icon-only toggle buttons in `<NavMenu>` and `<FloatingSupportWidget>` that lacked appropriate `aria-expanded` and dynamic `aria-label` properties.
- Updated main mobile navigation menu toggle.
- Updated user profile dropdown toggle.
- Updated floating support widget toggle.
- Ensured close buttons inside drawers/widgets have descriptive `aria-label`s.
- Created learning entry in `.jules/palette.md`.

Co-authored-by: secrooq <81346684+secrooq@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant