Update reset code based on the new OS image. Update ambient light threshold in toggle. - #118
Conversation
…eshold in toggle.
7fa5ce4 to
5d1a48b
Compare
| } | ||
|
|
||
| const LIGHT_THRESHOLD: u32 = 40; | ||
| const LIGHT_THRESHOLD: u32 = 20; |
There was a problem hiding this comment.
I think we should document how this threshold is derived, perhaps in a comment here.
On a side note for future work: what if this is a good number for our houses, but it doesn't work well for other users? How can we make this adapt to different conditions?
There was a problem hiding this comment.
It was derived empirically.
That's a good question. I'm not sure that the threshold needs to vary much in different houses. If we do see it perform poorly in some locations, then we can look into a solution.
There was a problem hiding this comment.
And just to clarify: I'm not saying 20 is the best, most optimized threshold. We probably can improve it by doing more experiments.
| .arg("--output=short-iso") | ||
| .arg("-u") | ||
| .arg("secluso.service") | ||
| .arg("secluso_camera_hub.service") |
There was a problem hiding this comment.
We have DEBUG_LOGS_FILENAME as a constant, what about secluso_camera_hub.service? It's used 3x across this file.
2 participants
Updated and tested reset and toggle with the new OS.
fixes secluso/os#20