Visualizer backport V3 to v2 - #42
Open
judgej wants to merge 5 commits into
Open
Conversation
The state and transition names can contain dashes, and those result in a syntax error in the generated dot file.
Contributor
Author
|
|
Contributor
Author
|
This is working for me nicely in Laravel 5.8 and PHP 7.3. Although I'll be upgrading the Laravel version soon, it's all about timing and compatibility with other packages, and not all projects are in a position to do that immediately. This PR tackles just the backport, with no feature changes, preserving all original committer credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the visualizer command from v3 to v2, for use with Laravel v5.