Migrate the metadata from setup.py into PEP 621-compliant pyproject.toml - #52
Open
KOLANICH wants to merge 2 commits into
Open
Migrate the metadata from setup.py into PEP 621-compliant pyproject.toml#52KOLANICH wants to merge 2 commits into
setup.py into PEP 621-compliant pyproject.toml#52KOLANICH wants to merge 2 commits into
Conversation
…ersion automatically from `git` history.
johnthedebs
reviewed
Oct 30, 2023
| else | ||
| echo -e "${YELLOW}--->${COLOR_OFF} Creating local python dist and wheel for manual release" | ||
| python setup.py sdist bdist_wheel > /dev/null | ||
| python -m build > dev.null |
Collaborator
There was a problem hiding this comment.
What's the thinking with this writing to dev.null instead of /dev/null?
There was a problem hiding this comment.
Seems like mostly like a typo to me. Is that the case, @KOLANICH?
Contributor
|
This would require updates for the minimum Python version + license, since they changed since the PR was created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.