✨ Add workflow control token syntax by sdougbrown · Pull Request #55 · sdougbrown/avenor

sdougbrown · 2026-06-16T18:42:48Z

Summary

add canonical <|workflow/status/team|> control token parsing
keep legacy [loop], [status], and [team: skip] markers for compatibility
update docs, templates, and tests to prefer the new token syntax

Closes #41

Tests

go test ./internal/digest ./internal/teamrunner ./internal/cli ./internal/looprunner
go test ./...

umpire-bot

This PR is marked... FOUL BALL. 👉

Warnings

Duplicate Documentation: docs/team.md:66 contains a duplicate H2 section "## How a team run works".
Logic Coupling: internal/digest/chunkbuf.go:80 uses a shared lastStatusKey for both ScanStatusAngle and ScanStatusMarker, risking incorrect suppression.
Code Duplication: internal/digest/loopmarker.go:15 duplicates phaseconfig.LoopDirectiveSeverity logic.
Test Duplication: internal/digest/chunkbuf_test.go:163 contains a test case nearly identical to TestChunkBufferLoopMarkerHighestSeverityWins.

Nits

Missing Test Case: internal/digest/chunkbuf_test.go:201 lacks a test for accumulating multiple angle tokens in the buffer.

Prior Findings Review

Fixed (2)

Prior findings that have been resolved.

internal/teamrunner/runner.go:631 — The use of `strings.TrimSpace(line)` is redundant because `teamSkipRe` is already anchored with `^\s*` and `\s*$`.
internal/digest/loopmarker.go:42 — The `continue` on a legacy `[loop: ...]` match makes the angle-token branch unreachable if both syntaxes appear on the same line. Add a comment to make this intentional precedence explicit.

Uncertain (1)

These prior findings could not be confidently classified against the current code.
A human should decide whether they remain relevant.

internal/digest/loopmarker.go:13

sdougbrown · 2026-06-16T19:27:23Z

👾 AI Agent

Addressed 4 inline comments across 2 files:

Fixed (3): removed redundant TrimSpace before teamSkipRe; loosened angle-token label/name parsing for | and >; added parser precedence clarification. Commit: 1a41806.
Accepted as-is (1): kept gofmt-only alignment in completePhaseRequirements; it has no behavior impact and reverting it would add churn.
Dismissed/clarified: the top-level “breaking change” warning is oversold — legacy [loop: ...], [status: ...], and [team: skip | ...] remain supported, while docs/templates now teach the new <|...|> syntax.

Review loop: 1 iteration. Tests passed:

go test ./internal/digest ./internal/teamrunner ./internal/cli ./internal/looprunner
go test ./...

sdougbrown · 2026-06-16T20:48:29Z

@umpire-bot review

umpire-bot · 2026-06-16T20:57:21Z

+// ScanStatusAngle runs ExtractStatusAngle over the accumulated buffer.
+// It returns ok=false for a status angle token that was already returned by
+// a previous call, preventing duplicate emissions.
+func (cb *ChunkBuffer) ScanStatusAngle() (phase, label string, ok bool) {


ScanStatusAngle and ScanStatusMarker share the lastStatusKey field in ChunkBuffer. This shared state could cause ScanStatusAngle to incorrectly suppress a valid marker if a ScanStatusMarker call was previously made with the same phase and label.

👾 AI Agent

Dismissed: this shared key is intentional. The canonical and legacy status syntaxes represent the same status update when phase+label match, so suppressing the duplicate is desired compatibility behavior. I also tightened ScanStatusAngle in 91eaa25 so it emits the first non-duplicate angle marker in stream order when multiple tokens are buffered.

umpire-bot · 2026-06-16T20:57:23Z

 	}
 }
+
+func TestChunkBufferAngleTokenLoopMarker(t *testing.T) {


TestChunkBufferAngleTokenLoopMarker is structurally identical to TestChunkBufferLoopMarkerHighestSeverityWins. Consolidate these into a parameterized table test to reduce duplication.

👾 AI Agent

Dismissed: the tests are intentionally parallel, one protecting legacy [loop: ...] scanning and one protecting canonical <|workflow: ...|> scanning through the same streaming scanner. Consolidating them would make the canonical coverage less obvious for little gain.

sdougbrown · 2026-06-16T21:59:00Z

👾 AI Agent

Addressed 5 new comments across 3 files:

Fixed (3): removed the duplicate team docs section; added a sync comment for directive severity; expanded status-angle chunk-buffer coverage and adjusted scanning to emit the first non-duplicate marker in stream order. Commit: 91eaa25.
Dismissed (2): shared lastStatusKey is intentional compatibility dedup for equivalent canonical/legacy status markers; separate legacy-vs-canonical loop marker tests are deliberate coverage.

Review loop: 1 iteration. Tests passed:

go test ./internal/digest ./internal/teamrunner ./internal/cli ./internal/looprunner
go test ./...

✨ feat: add workflow control tokens

59f52e7