Skip to content

Add missing storage version - #465

Open
aveyrenc wants to merge 2 commits into
sdcio:mainfrom
aveyrenc:fix-missing-storage-version
Open

Add missing storage version#465
aveyrenc wants to merge 2 commits into
sdcio:mainfrom
aveyrenc:fix-missing-storage-version

Conversation

@aveyrenc

Copy link
Copy Markdown

Since commit e4f94d1 the make manifests command fails with these errors:

test -s /home/user/src/github.com/sdcio/config-server/bin/controller-gen || GOBIN=/home/user/src/github.com/sdcio/config-server/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.20.0
mkdir -p crds
/home/user/src/github.com/sdcio/config-server/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./apis/..." output:crd:artifacts:config=crds
github.com/sdcio/config-server/apis/config:-: CRD for TargetClearDeviation.config.sdcio.dev has no storage version
github.com/sdcio/config-server/apis/config:-: CRD for TargetRunningConfig.config.sdcio.dev has no storage version
github.com/sdcio/config-server/apis/config/v1alpha1:-: CRD for TargetConfigBlame.config.sdcio.dev has no storage version
Error: not all generators ran successfully
run `controller-gen rbac:roleName=manager-role crd webhook paths=./apis/... output:crd:artifacts:config=crds -w` to see all available markers, or `controller-gen rbac:roleName=manager-role crd webhook paths=./apis/... output:crd:artifacts:config=crds -h` for usage
make: *** [crds] Error 1

This adds the missing storage version to fix manifests generation and includes a fresh version of the manifests.

@aveyrenc
aveyrenc marked this pull request as ready for review July 15, 2026 08:09
@aveyrenc
aveyrenc requested a review from a team as a code owner July 15, 2026 08:09
@henderiw

Copy link
Copy Markdown
Contributor

These subresources are no longer having a storage backend as they became sub resources.
So we should not change them to be storage resources. We need to check how the issue manifests itself as I can normally run the make commands w/o issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants