Skip to content

fix: don't enforce identical df index on {obs,var}m - #2641

Open
ilan-gold wants to merge 5 commits into
mainfrom
ig/aligned_df
Open

fix: don't enforce identical df index on {obs,var}m#2641
ilan-gold wants to merge 5 commits into
mainfrom
ig/aligned_df

Conversation

@ilan-gold

Copy link
Copy Markdown
Contributor

See scverse/anndata-rs#44 for more info, but since this isn't technically in our spec (and I find it wasteful in any case to enforce), I think removing it is reasonable. I've already added a note to revisit this in #2060.

We could in theory warn users about the mismatch, but that would mean that everything produced by rustar-alginer (without a fix there enforcing the duplication of the index across multi-dim mappings) would yield the warning.

I'm open to suggestions, but this seemed the least invasive!

  • Closes #
  • Tests added
  • Release note not necessary because:

@ilan-gold ilan-gold added this to the 0.13.4 milestone Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (ad6c4f4) to head (0e8b204).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
- Coverage   87.60%   84.84%   -2.76%     
==========================================
  Files          49       49              
  Lines        8123     8110      -13     
==========================================
- Hits         7116     6881     -235     
- Misses       1007     1229     +222     
Files with missing lines Coverage Δ
src/anndata/_core/aligned_mapping.py 94.91% <ø> (+0.38%) ⬆️

... and 13 files with indirect coverage changes

@ilan-gold
ilan-gold marked this pull request as ready for review September 8, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant