feat: allow writing into open HDF5 file - #2637
Closed
flying-sheep wants to merge 7 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ig/memory_store_for_tests #2637 +/- ##
=============================================================
+ Coverage 85.83% 85.85% +0.02%
=============================================================
Files 49 49
Lines 8133 8168 +35
=============================================================
+ Hits 6981 7013 +32
- Misses 1152 1155 +3
|
flying-sheep
marked this pull request as ready for review
September 7, 2026 10:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided against allowing to pass an open (Python) file, since
h5py.File? As seen in this PR, to open a BytesIO in memory, two parameters need to be passed toh5py.FileTODO:
test if this actually speeds up tests like @ilan-gold’s zarr variant of this
/edit: no difference, so let’s forget about it.