Conversation
…mment
The { type: "openSettings" } message was never posted by script.js and had
no corresponding handler in webview-provider.ts; the comment was stale.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Each view contributes meridian.openSettings directly to its view/title with
the Meridian brand glyph (themed media/glyph-{light,dark}.svg) and a
'Meridian Settings' label, so it reads as distinct from the host's settings
cog rather than duplicating it. On Cursor — where the host cog mis-resolves
to Cursor's top-level settings — the labeled action is unmistakably the
correct, working target.
Removes the $(kebab-vertical) 'Meridian Actions' quick-pick (showActions
commands, VIEW_ACTIONS, showActionsQuickPick) and its redundant in-menu
Refresh; Git/Hygiene already carry an inline Refresh. Adds a manifest test
asserting openSettings is wired into all three view titles.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Dated Update note: kebab quick-pick -> dedicated branded view/title action, the themed-glyph rationale (file-path command icons are not host-tinted, so explicit light/dark variants; the cube's edges depend on subpath winding + nonzero fill-rule, so path/fill-rule must not be altered), and the unchanged residual (host cog unremovable, still mis-routes on Cursor — upstream defect). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
npm install corrected a stale top-level version field (1.8.0 -> 2.4.0) matching package.json; no dependency tree changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the confusing dual-settings affordance in the Meridian view title bars. On Cursor the host-synthesized settings cog mis-routes to Cursor's top-level settings (it cannot be suppressed), while Meridian also surfaced its own settings entry — two controls that looked the same but behaved differently.
Rather than fight the unremovable host cog, this brands and names Meridian's own affordance so it reads as distinct:
meridian.openSettingsdirectly to itsview/titlewith the Meridian brand glyph (themedmedia/glyph-{light,dark}.svg) and a "Meridian Settings" label.@ext:scscodes.meridian(verified working on Cursor).$(kebab-vertical)"Meridian Actions" quick-pick (showActionscommands,VIEW_ACTIONS,showActionsQuickPick) and its redundant in-menu Refresh — Git/Hygiene already carry an inline Refresh. Net code simplification.This evolves ADR 016 Rule 1 ("distinct glyph over duplicate gear") to also name the owner; documented in a dated Update note.
Commits
chore(hygiene)— drop a deadopenSettingsentry from a webview protocol commentfeat(ui)— branded "Meridian Settings" title action replaces the kebabdocs(adr-016)— record the supersession + themed-glyph rationalechore— sync stalepackage-lock.jsonversion field (no dependency changes)Testing
tsc --noEmitclean; 322/322 tests pass.viewActions.test.ts(quick-pick) with a manifest test assertingopenSettingsis wired into all three view titles.Manual verification (host-dependent, not automatable in CI)
@ext:scscodes.meridianon Cursor and VS Code.Known residual
The host settings cog remains unremovable and still mis-routes on Cursor — a host defect to report upstream. The branded action mitigates but does not eliminate a muscle-memory click on it.
🤖 Generated with Claude Code