Skip to content

Skip quoting for URLs and patterns that need none - #91

Merged
wRAR merged 2 commits into
scrapy:masterfrom
AdrianAtZyte:quote-fast-path
Sep 19, 2026
Merged

wRAR merged 2 commits into
scrapy:masterfrom
AdrianAtZyte:quote-fast-path

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (700ed93) to head (146342f).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   98.21%   98.27%   +0.05%     
==========================================
  Files           5        5              
  Lines         393      406      +13     
  Branches       80       85       +5     
==========================================
+ Hits          386      399      +13     
  Misses          4        4              
  Partials        3        3              
Files with missing lines Coverage Δ
src/protego/_utils.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Sep 16, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 30.65%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 1 untouched benchmark

Performance Changes

Benchmark BASE HEAD Efficiency
test_match 2 ms 1.5 ms +30.65%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing AdrianAtZyte:quote-fast-path (146342f) with master (700ed93)

Open in CodSpeed

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review September 17, 2026 08:00
@wRAR
wRAR merged commit 357ea7f into scrapy:master Sep 19, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants