Skip to content

Support s being missing - #74

Merged
AdrianAtZyte merged 1 commit into
scrapy:masterfrom
AdrianAtZyte:request-rate-parsing-corruption-fix
Jun 11, 2026
Merged

AdrianAtZyte merged 1 commit into
scrapy:masterfrom
AdrianAtZyte:request-rate-parsing-corruption-fix

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Contributor

Fixes #73.

@AdrianAtZyte
AdrianAtZyte requested a review from wRAR June 11, 2026 09:34
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.97%. Comparing base (a01ca34) to head (8b94eb2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   97.94%   97.97%   +0.02%     
==========================================
  Files           5        5              
  Lines         341      345       +4     
  Branches       68       69       +1     
==========================================
+ Hits          334      338       +4     
  Misses          4        4              
  Partials        3        3              
Files with missing lines Coverage Δ
src/protego/_ruleset.py 98.19% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdrianAtZyte
AdrianAtZyte merged commit 0e256b2 into scrapy:master Jun 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request-rate parsing silently corrupts numeric periods (strips last digit as a unit)

2 participants