fix(twitter): add advanced_search/_all aliases on TweetsClient (SCR-52)#8
Merged
Merged
Conversation
Customers called client.twitter.tweets.advanced_search(...) (the REST endpoint name) and hit AttributeError — the SDK method is search()/search_all(). Add thin delegating aliases so the endpoint-named call works.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Second half of SCR-52. A customer hit
AttributeError: 'TweetsClient' object has no attribute 'advanced_search'— they called the REST endpoint name (/v1/twitter/tweets/advanced_search) on the SDK, where the method issearch()/search_all().Adds thin delegating aliases
advanced_search/advanced_search_allso the endpoint-named call just works. No logic duplication — they call straight through tosearch/search_all.Test
tests/test_twitter_tweets_aliases.py— asserts both aliases hit/v1/twitter/tweets/advanced_searchand return parsed tweets. 16 twitter/pagination tests pass; ruff clean.Part of SCR-52 (the repeat-page half shipped in #7).