[ESSdiffraction] Save XYE files in tests and apply masks - #673
Merged
Conversation
nvaytet
approved these changes
Jul 23, 2026
| """ | ||
| result.save(output_folder / "dream_reduced.cif") | ||
|
|
||
| wf.bind_and_call(save_xye) |
Member
There was a problem hiding this comment.
Is the reason why we don't use bind_and_call for CIF files because we want to add the result.comment?
At first glance it seems strange that we use one method for CIF file and another for XYE file.
Member
Author
There was a problem hiding this comment.
We could handle the comment differently. And having a free-form comment for XYE or other files could be useful, too. The difference comes mainly from there being this CIF object that you build in memory. So the workflow has something to return. But we don't have that for other formats. (We do for SQW but that is way more complicated.)
We can talk about a good, common interface if you like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #618 and #672
The XYE files do not contain any metadata (see scipp/scippneutron#706) but they should be good enough to run some integration tests.