Skip to content

FIX sample_mask cannot mask nan from feature generators - #257

Merged
MatthewSZhang merged 3 commits into
mainfrom
sample-mask
Jun 24, 2026
Merged

FIX sample_mask cannot mask nan from feature generators#257
MatthewSZhang merged 3 commits into
mainfrom
sample-mask

Conversation

@MatthewSZhang

Copy link
Copy Markdown
Collaborator

Checklist

  1. make sample_mask also mask nan from feature generator
  2. add test to check this issue

@MatthewSZhang MatthewSZhang self-assigned this Jun 24, 2026
@MatthewSZhang MatthewSZhang added the bug Something isn't working label Jun 24, 2026
@MatthewSZhang

Copy link
Copy Markdown
Collaborator Author

Intersphinx error when fetching SciPy docs

See scipy/docs.scipy.org#102 (comment)

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1966466) to head (25d594c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1000      1002    +2     
=========================================
+ Hits          1000      1002    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthewSZhang
MatthewSZhang merged commit 2ddb3ac into main Jun 24, 2026
22 checks passed
@MatthewSZhang
MatthewSZhang deleted the sample-mask branch June 24, 2026 06:58
github-actions Bot added a commit that referenced this pull request Jun 24, 2026
* FIX sample_mask cannot mask nan from feature generators

* update lock

* fix docstring 2ddb3ac
@MatthewSZhang MatthewSZhang changed the title Sample mask FIX sample_mask cannot mask nan from feature generators Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG sample_mask in LazyFastCan cannot mask invalid data given by feature generator

1 participant