Fix code for manifolds in 2D.#230
Merged
Merged
Conversation
Remove premature stop of linesearch. Add new test for 1D manifold in 2D space. Fix initialization of initial guess on intervals
jorgensd
commented
Jun 10, 2026
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
finsberg
approved these changes
Jun 10, 2026
| for (std::size_t l = 0; l < tdim * gdim; l++) | ||
| jac_norm += J_buffer[l] * J_buffer[l]; | ||
| T scaled_tol_grad = tol_grad * std::max(jac_norm, T(1)); | ||
| T scaled_tol_grad = tol_grad * tol_grad * std::max(jac_norm, T(1)); |
Member
There was a problem hiding this comment.
Did you add an extra tol_grad here?
Member
Author
There was a problem hiding this comment.
This is to make the C++ and Python implementation equivalent, as we use linalg norm in python, but gradient squared in C++ (sqrt are expensive).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove premature stop of linesearch.
Add new test for 1D manifold in 2D space.
Fix initialization of initial guess on intervals