Adding overload for DirichletBC#49
Open
finsberg wants to merge 6 commits into
Open
Conversation
finsberg
force-pushed
the
finsberg/dirichlet-bc
branch
from
46020b5 to
9db8d73
Compare
finsberg
force-pushed
the
finsberg/dirichlet-bc
branch
from
71ad414 to
b438d67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the overloaded
DirichletBCtype and its corresponding PyAdjoint block (DirichletBCBlock) to dolfinx-adjoint. This enables the tracing and optimization of boundary conditions that depend on control parameters, such as time-varying boundary values or boundary control problems.Key Changes:
Added
DirichletBCoverload (src/dolfinx_adjoint/types/dirichletbc.py): Wraps dolfinx.fem.DirichletBC as a FloatingType and eagerly annotates it to the working tape.Added
DirichletBCBlock(src/dolfinx_adjoint/blocks/dirichletbc.py): A PyAdjoint block that registers the underlying FEniCSx Function or Constant as a dependency and handles the forward recomputation.In-place Tape Replay (
src/dolfinx_adjoint/blocks/function_assigner.py): Updated FunctionAssignBlock to update the FEniCSx function arrays in-place during recompute_component().Solver Dependency Tracking (
src/dolfinx_adjoint/blocks/solvers.py): Updated LinearProblemBlock to correctly detect and register dependencies from provided boundary conditions.Testing (
tests/test_dirichlet_bc.py): Added test coverage for tape recording, the annotate=False bypass, block recomputations, and a full time-dependent PDE tape replay.