Skip to content

fix: switch set score display when switching sides - #4

Merged
nikolaischunk merged 2 commits into
mainfrom
copilot/fix-set-score-switch-sides
Apr 10, 2026
Merged

fix: switch set score display when switching sides#4
nikolaischunk merged 2 commits into
mainfrom
copilot/fix-set-score-switch-sides

Conversation

Copilot AI commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

The set score widget (e.g. 2-1) always rendered Team A's count on the left regardless of which side Team A was visually on, making it inconsistent after switching sides.

Change

In page.tsx, replace the raw setsWonA/setsWonB props passed to ScoreboardHeader and DesktopBottomMenu with the already-swap-aware leftTeam.setsWon / rightTeam.setsWon:

// Before
setsWonA={scoreboard.setsWonA}
setsWonB={scoreboard.setsWonB}

// After
setsWonA={scoreboard.leftTeam.setsWon}
setsWonB={scoreboard.rightTeam.setsWon}

leftTeam/rightTeam are already resolved from isSwapped in the controller, so this mirrors the existing pattern used by DesktopBottomMenu for per-set history scores.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/volleyball-scoreboard/volleyball-scoreboard/node_modules/next/dist/compiled/jest-worker/processChild.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@vercel

vercel Bot commented Apr 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
volleyball-scoreboard Ready Ready Preview, Comment Apr 9, 2026 5:48pm

Copilot AI changed the title [WIP] Fix set score display when switching sides fix: switch set score display when switching sides Apr 9, 2026
Copilot AI requested a review from nikolaischunk April 9, 2026 17:48
@nikolaischunk
nikolaischunk marked this pull request as ready for review April 10, 2026 08:31
@nikolaischunk
nikolaischunk merged commit 5fd841c into main Apr 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: set score is not switched when switching sides

2 participants