fix: switch set score display when switching sides - #4
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Agent-Logs-Url: https://github.com/schunkdev/volleyball-scoreboard/sessions/98e7219c-4b3f-4a60-a1ab-503dc5565546 Co-authored-by: nikolaischunk <58025175+nikolaischunk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix set score display when switching sides
fix: switch set score display when switching sides
Apr 9, 2026
nikolaischunk
approved these changes
Apr 10, 2026
nikolaischunk
marked this pull request as ready for review
April 10, 2026 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set score widget (e.g.
2-1) always rendered Team A's count on the left regardless of which side Team A was visually on, making it inconsistent after switching sides.Change
In
page.tsx, replace the rawsetsWonA/setsWonBprops passed toScoreboardHeaderandDesktopBottomMenuwith the already-swap-awareleftTeam.setsWon/rightTeam.setsWon:leftTeam/rightTeamare already resolved fromisSwappedin the controller, so this mirrors the existing pattern used byDesktopBottomMenufor per-set history scores.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fonts.googleapis.com/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/volleyball-scoreboard/volleyball-scoreboard/node_modules/next/dist/compiled/jest-worker/processChild.js(dns block)If you need me to access, download, or install something from one of these locations, you can either: