Rename unfold arguments for increased usefulness - #83
Merged
arvyy merged 5 commits intoAug 23, 2026
Conversation
Also fixes the order of args in char-set-unfold
Contributor
Author
|
I also renamed args in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unfoldarguments are obscure and their names don’t tell much. I always have to read the specification to understand what they mean. All the other*-unfoldprocedures in all the other SRFIs have better names (stop?,mapper,successor) that allow to understand how the procedure works, at a glance.Thus this PR—making
unfoldmore understandable and consistent with the ecosystem.I also amended the validatedata.scm to use
(scheme base)for Chicken 6 compatibility.