[codex] Make developer targets opt-in for consumers#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCARF_CPP_BUILD_TESTSandSCARF_CPP_BUILD_EXAMPLEStoONonly whenscarf-cppis the top-level CMake project.OFFwhen the SDK is consumed as a subproject, such as throughFetchContentoradd_subdirectory.Why
Consumers should be able to pull the SDK from source without unexpectedly adding the SDK's tests and examples to their own build graph. Local development of this repo still keeps the existing convenient default behavior.
Validation
cmake -S . -B /tmp/scarf-cpp-top-build && cmake --build /tmp/scarf-cpp-top-build && ctest --test-dir /tmp/scarf-cpp-top-build --output-on-failureadd_subdirectory(/Users/avi/dev/cpp-sdk scarf-cpp-build)configured, built, and ran successfully while confirming the SDK test/example targets were not created.git diff --check