APP-21126 add initial C++ SDK#1
Merged
Merged
Conversation
aviaviavi
approved these changes
May 28, 2026
aviaviavi
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the current diff, PR description, prior discussion state, and CI for this initial C++ SDK. The API, request construction, opt-out handling, libcurl transport, CMake install/export path, README, and no-network tests look sound for this initial release.
Validation checked during review:
- GitHub Actions
CIcompleted successfully on the head commit. - Built and ran
ctestlocally from a scratch clone. - Installed the package locally and built a tiny downstream
find_package(scarf-cpp CONFIG REQUIRED)consumer against the installed config.
I did not find any blocking correctness, security/privacy, data handling, packaging, or test coverage issues in the current PR.
AI-generated review by Codex in the Codex desktop harness using GPT-5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scarf::EventLoggerValidation
PATH="/usr/local/opt/llvm@20/bin:$PATH" /usr/local/bin/treefmt CMakeLists.txt include/scarf/event_logger.hpp src/event_logger.cpp src/curl_transport.cpp tests/event_logger_test.cpp examples/basic.cpp README.md .github/workflows/ci.yml treefmt.toml .clang-formatCXX=/usr/local/opt/gcc/bin/g++-15 cmake -S . -B build -DSCARF_CPP_BUILD_TESTS=ONcmake --build build --parallelctest --test-dir build --output-on-failurecmake --install build --prefix /tmp/scarf-cpp-installfind_package(scarf-cpp CONFIG REQUIRED)consumer against/tmp/scarf-cpp-installNotes: local Apple clang/CLT on this host is missing standard library headers (
fatal error: 'chrono' file not found), so local validation used Homebrew GCC 15. The GitHub Actions matrix covers Ubuntu, macOS, and Windows with the platform toolchains.Linear: APP-21126