Skip to content

Task status update and execution handling - #197

Merged
chdinh merged 38 commits into
mainfrom
update-task-status
Aug 30, 2025
Merged

Task status update and execution handling#197
chdinh merged 38 commits into
mainfrom
update-task-status

Conversation

@schote

@schote schote commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator
  • Ensure status INPROGRESS for acquisition and workflow tasks
  • Set progress to 100% when task finished
  • Update visual appearence of task when processing
  • Add ItemStatus.ERROR (& removed status DELETED)
  • Add MRD header to sequence and transfer it to device
  • Fixed bug which lead to incorrect device status
  • Add pydantic model for device status
  • Add frontend status bar with device status and service status
  • Add license to all subpackages
  • Fixed reconstruction workflow
  • Structured orchestration-engine (former dagster sub package)
  • Trigger frontend rendering (dicom & raw data) on task status change

closes #166
closes #145

@schote
schote marked this pull request as ready for review August 26, 2025 22:56
@schote
schote requested a review from jobehrens August 27, 2025 16:39
@chdinh

chdinh commented Aug 27, 2025

Copy link
Copy Markdown
Member

When building everything from scratch in a clean docker environment. The Device Manager throws the following ImportError: cannot import name 'DeviceStatus' from 'scanhub_libraries.models' (/usr/local/lib/python3.13/site-packages/scanhub_libraries/models.py)

@schote

schote commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator Author

When building everything from scratch in a clean docker environment. The Device Manager throws the following ImportError: cannot import name 'DeviceStatus' from 'scanhub_libraries.models' (/usr/local/lib/python3.13/site-packages/scanhub_libraries/models.py)

Make sure you are using the local base image (see .env file). Per default die base image hosted on GHCR is used, which does not contain the changes made in the PR.

@chdinh

chdinh commented Aug 28, 2025

Copy link
Copy Markdown
Member

getting now another error during docker compose up: time="2025-08-28T17:32:31+02:00" level=warning msg="The "DATA_LAKE_DIR" variable is not set. Defaulting to a blank string."
invalid spec: :/data: empty section between colons

@schote

schote commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator Author

getting now another error during docker compose up: time="2025-08-28T17:32:31+02:00" level=warning msg="The "DATA_LAKE_DIR" variable is not set. Defaulting to a blank string." invalid spec: :/data: empty section between colons

My bad, I didn't commit the .env update, the data_lake directory is now configurable. After the latest changes I would suggest to clean and rebuild the project, I updated the packaging of our base image.
Also, please re-install the device-sdk package /tools/device-sdk (pip install --ignore-installed -e .)

@chdinh

chdinh commented Aug 30, 2025

Copy link
Copy Markdown
Member

yes, everythings seems to be working now - thx👍

@chdinh
chdinh merged commit 8df2410 into main Aug 30, 2025
11 checks passed
@schote
schote deleted the update-task-status branch October 7, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementation of soft-delete SWR_FR_0250: Retrieve device status (device manager) and expose status to UI

2 participants