perf: cache removeDiacritics results in getMatches to avoid redundant… - #545
Open
yoshi-taka wants to merge 4 commits into
Open
perf: cache removeDiacritics results in getMatches to avoid redundant…#545yoshi-taka wants to merge 4 commits into
yoshi-taka wants to merge 4 commits into
Conversation
… computation getMatches() is called for each search result (up to 50) and recomputes removeDiacritics() on the full document text every time when ignoreDiacritics is enabled. Cache results with a bounded Map (max 100 entries) using a key that includes the ignoreArabicDiacritics setting flag to avoid stale entries when the setting changes. FIFO eviction keeps memory bounded.
Owner
|
Hello and thanks for your PR :) Could you please just solve the conflict, so I can merge it? Thank you. |
Exact-term matching only evaluates the candidate results after they have been limited. Normalize the original document content at that point instead of keeping a normalized full-text copy in every cached document.
Resolve conflict in text-processing.ts by keeping both highlightRegexCache and diacriticsCache
Author
|
I've resolved the conflicts. Sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… computation
getMatches() is called for each search result (up to 50) and recomputes removeDiacritics() on the full document text every time when ignoreDiacritics is enabled.
Add a small bounded cache for normalized text to avoid repeated full-string normalization during repeated search-result rendering passes.
The cache:
This trades a small amount of bounded memory for less repeated normalization work in the search rendering path.