Check typing instead of string matching - #58
Open
ljos wants to merge 1 commit into
Open
Conversation
|
Thanks for working on Python 3.14 compatibility — this kind of modernization is welcome. I reviewed the diff and have a few concerns before I can approve:
I like the direction, but I’d like to see the compatibility story tightened before approving. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi--I am trying to get this working on python3.14 and there has been some changes to the type system so the string checks that were there does not work anymore. I updated the code to look at the types instead.
This was preventing me from even importing the library.
(I am now getting a segfault when I try to create a relation, so you might see some more PRs from me).