Skip to content

Drop the dead MongoDB oplog-tailing code from mongoclient - #2684

Draft
delthas wants to merge 3 commits into
development/8.5from
improvement/ARSN-622/drop-mongoclient-oplog-consumer
Draft

Drop the dead MongoDB oplog-tailing code from mongoclient#2684
delthas wants to merge 3 commits into
development/8.5from
improvement/ARSN-622/drop-mongoclient-oplog-consumer

Conversation

@delthas

@delthas delthas commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The mongoclient LogConsumer (and its ListRecordStream) tailed MongoDB's internal replica-set oplog (local.oplog.rs). It has been broken on MongoDB >= 7.1 since the oplog h field it uses as a cursor was removed — ARSN-545, closed Won't Fix — and its only consumer org-wide, backbeat's MongoLogReader (logSource: "mongo"), was removed in BB-836 (scality/backbeat#2795).

Changes:

  • Delete lib/storage/metadata/mongoclient/LogConsumer.js and ListRecordStream.js, their unit tests, and the LogConsumer export from the mongoclient block in index.ts.
  • MongoReadStream (readStream.js) remains — used by MongoClientInterface for listings, unrelated to the oplog. The bucketclient LogConsumer (raft log) is untouched.

To land after scality/backbeat#2795 merges. Backbeat branches < 9.5 still reference this export but pin arsenal by commit, so they are unaffected until an arsenal bump.

Issue: ARSN-622

@bert-e

bert-e commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Aug 7, 2026
@bert-e

bert-e commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@delthas
delthas force-pushed the improvement/ARSN-622/drop-mongoclient-oplog-consumer branch from a45c050 to 390c616 Compare August 7, 2026 13:46
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.59%. Comparing base (e4fdcc8) to head (a309450).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.5    #2684      +/-   ##
===================================================
- Coverage            74.73%   74.59%   -0.14%     
===================================================
  Files                  229      227       -2     
  Lines                18695    18567     -128     
  Branches              3894     3842      -52     
===================================================
- Hits                 13971    13850     -121     
+ Misses                4719     4712       -7     
  Partials                 5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

delthas added 2 commits August 7, 2026 15:53
The mongoclient LogConsumer (and its ListRecordStream) tailed
MongoDB's internal replica-set oplog (local.oplog.rs). It has been
broken on MongoDB >= 7.1 since the oplog "h" field it uses as a
cursor was removed (see ARSN-545), and its only consumer, backbeat's
MongoLogReader (logSource "mongo"), was removed in BB-836.

MongoReadStream (readStream.js) remains: it is used by
MongoClientInterface for listings and is unrelated to the oplog.

Issue: ARSN-622
@delthas
delthas force-pushed the improvement/ARSN-622/drop-mongoclient-oplog-consumer branch from 390c616 to a309450 Compare August 7, 2026 13:54
@scality scality deleted a comment from claude Bot Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants